Debug and test SRJaxAgent - #23
Open
krzysztofrusek wants to merge 3 commits into
Open
Conversation
PySR's jax callable indexes X by fit-time column, and JAX clamps out-of-range indices instead of raising. Running a model distilled from a window_size=10 history under the default window_size=5 therefore read the wrong columns, collapsed the expression to a constant, and pinned every station to TX for the whole rollout: constant collisions, zero throughput, flat plots. SRJaxAgent now compares feature_names_in_ against the feature count the simulation supplies and names the window size to use. The sr-run target passes that window size explicitly, and defaults to 10 epochs since the all_* plots draw one point per epoch and a single-epoch run renders as blank axes. Also adds the unit test for history_reshape, covering the row and column ordering the CSV columns and the agent both depend on. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Claude znalazł bug w eksporcie, teraz to juz jakoś działa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #22